Add guard check for signing algorithm #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinr1234
approved these changes
Apr 20, 2023
khancode
approved these changes
Apr 20, 2023
khancode
requested changes
Apr 20, 2023
|
Can you add a test where you pass the wrong value and check that it throws an exception? |
|
Please update the changelog. |
mvadari
reviewed
Apr 24, 2023
| it('generates a new wallet using an invalid/unknown algorithm', function () { | ||
| const algorithm = "test" | ||
|
|
||
| assert.throws(() => { Wallet.generate(algorithm) }, /Invalid cryptographic signing algorithm/) |
There was a problem hiding this comment.
You'll need to ignore the TypeScript check here for tests to pass
mvadari
approved these changes
Apr 24, 2023
ckniffen
reviewed
Apr 24, 2023
| it('generates a new wallet using an invalid/unknown algorithm', function () { | ||
| const algorithm = "test" | ||
|
|
||
| assert.throws(() => { Wallet.generate(algorithm) }, /Invalid cryptographic signing algorithm/) |
There was a problem hiding this comment.
Need to add //@ts-expect-error. This will allow the test to compile even though the type is wrong to simulate how it might work if using js.
There was a problem hiding this comment.
Or just cast it via as unknown as ExpectedType
|
note: awaiting response from @wojake |
Added `//@ts-expect-error` to allow a test to check a bad parameter.
ckniffen
approved these changes
May 16, 2023
khancode
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
You could put in a random string and it'll still work, we should be able to tell that the function generated a seed according to the right algorithm. Feel free to make changes to this PR since I have no clue if this works.
Type of Change
Before / After
Test Plan