Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency size #1057

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Reduce dependency size #1057

merged 1 commit into from
Oct 25, 2019

Conversation

intelliot
Copy link
Collaborator

We can cut the size of the npm tarball by about 78% by excluding the other files in build/ (including only ripple-latest-min.js, which I think is the one that people should use most of the time).

  • Remove .npmignore since it is overridden by package.json 'files'
  • Include build/ripple-latest-min.js, not everything in build/

Before:

% npm publish --dry-run
[...]
npm notice === Tarball Details === 
npm notice name:          ripple-lib                              
npm notice version:       1.4.0-b2                                
npm notice package size:  1.9 MB                                  
npm notice unpacked size: 7.8 MB                                  
npm notice shasum:        5a28c5b629bdfa7299381d9d639673d0407f3233
npm notice integrity:     sha512-90mGTucpK5CcR[...]onwZt9ReLv7Yg==
npm notice total files:   570

After:

% npm publish --dry-run
[...]
npm notice === Tarball Details === 
npm notice name:          ripple-lib                              
npm notice version:       1.4.0-b2                                
npm notice package size:  419.5 kB                                
npm notice unpacked size: 1.6 MB                                  
npm notice shasum:        7ca4fc567916666447363a9be47f5305a727ba77
npm notice integrity:     sha512-VuyZ7b1T1gOOC[...]lmX8O4/96Dstw==
npm notice total files:   566

- Remove .npmignore since it is overridden by package.json 'files'
- Include build/ripple-latest-min.js, not everything in build/
@intelliot intelliot merged commit fcd6b43 into develop Oct 25, 2019
@intelliot intelliot deleted the reduce-dep-size branch October 25, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants