Python/JS code sample for Memo #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mDuo13
added
the
bounties
small changes in order for the js code sample to be comparable to the python code sample
ckniffen
reviewed
Jan 24, 2023
khancode
suggested changes
Jan 24, 2023
JST5000
reviewed
Jan 30, 2023
JST5000
reviewed
Jan 30, 2023
JST5000
reviewed
Jan 30, 2023
JST5000
reviewed
Jan 30, 2023
|
Not sure if there's a good spot to put this information, but Memos are only viewable if you ask a node that "remembers" the ledger where the transaction was submitted. So, full-history nodes will always remember, and for recent transactions most validators will be able to look up memos with the |
JST5000
reviewed
Jan 30, 2023
JST5000
reviewed
Jan 30, 2023
JST5000
reviewed
Jan 30, 2023
JST5000
reviewed
Jan 30, 2023
JST5000
reviewed
Jan 30, 2023
Co-authored-by: Jackson Mills <[email protected]>
Co-authored-by: Jackson Mills <[email protected]>
Co-authored-by: Jackson Mills <[email protected]>
Co-authored-by: Jackson Mills <[email protected]>
Co-authored-by: Jackson Mills <[email protected]>
Co-authored-by: Jackson Mills <[email protected]>
Co-authored-by: Jackson Mills <[email protected]>
ckniffen
approved these changes
Jan 31, 2023
JST5000
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate and send a Memo.
This is work for a XRPL Bounty @ XRPLBounties/Proposals for Milestone 7 and XRPLBounties/Proposals for Milestone 10