Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account_info signer_list does not match API response #938

Closed
nkramer44 opened this issue Nov 30, 2020 · 5 comments
Closed

account_info signer_list does not match API response #938

nkramer44 opened this issue Nov 30, 2020 · 5 comments

Comments

@nkramer44
Copy link
Contributor

The docs for the account_info response fields say that signer_lists should exist at the root level of the response. However, the actual API response puts signer_lists under account_data, which is an AccountRoot object.

I'm not sure if this is a bug in the rippled code or in the docs, but it's a bit misleading as is, because the docs for AccountRoot do not mention signer_lists.

@mDuo13
Copy link
Collaborator

mDuo13 commented Nov 30, 2020

Yes, signer lists are not part of the AccountRoot object, so in the code this is either a bug or poor API design, but that is what the code does, so the docs should probably fix this. (And we should also change this in a future version of the API.)

@Frassle
Copy link
Contributor

Frassle commented Feb 11, 2021

Does it make sense to move this field as part of the api_version:2 work currently being done on rippled?

@mDuo13
Copy link
Collaborator

mDuo13 commented Feb 11, 2021

Yes, I think it does.

@q411
Copy link

q411 commented Apr 1, 2021

XRPLF/rippled#3770

Frassle added a commit to Ibasa/rippled that referenced this issue Jun 13, 2021
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue Jul 21, 2021
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue Jul 21, 2021
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue Jul 27, 2021
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue Jul 27, 2021
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue Jul 27, 2021
@intelliot
Copy link
Contributor

This will be addressed in api_version 2. Details: https://github.com/xrplf/rippled/blob/develop/API-CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants