DRAFT: Require a message on "Application::signalStop"

[ximinez]

High Level Overview of Change

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (a079bac) to head (9a32a66).

Files with missing lines	Patch %	Lines
src/xrpld/app/main/Application.cpp	0.0%	3 Missing ⚠️
src/xrpld/rpc/handlers/Stop.cpp	0.0%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5255     +/-   ##
=========================================
- Coverage     78.2%   78.2%   -0.0%     
=========================================
  Files          790     790             
  Lines        67639   67638      -1     
  Branches      8160    8163      +3     
=========================================
- Hits         52869   52860      -9     
- Misses       14770   14778      +8     

Files with missing lines	Coverage Δ
src/xrpld/app/main/Application.h	100.0% <ø> (ø)
src/xrpld/rpc/handlers/Stop.cpp	0.0% <0.0%> (ø)
src/xrpld/app/main/Application.cpp	69.3% <0.0%> (+0.1%)	⬆️

... and 2 files with indirect coverage changes