Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Visual Studio CI to VS 2022, and add VS Debug builds #5240

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Jan 9, 2025

High Level Overview of Change

Currently, we only run one CI job for Windows: MSVC 2019 Release.
This adds Debug builds, and MSVC 2022, leading to a total of 4:

  • MSVC 2019 Release
  • MSVC 2019 Debug
  • MSVC 2022 Release
  • MSVC 2022 Debug

Context of Change

There are two main reasons to add these builds.

  1. Visual Studio 2019 is on its way to becoming deprecated, if it's not deprecated already.
  2. My personal workstation is having problems building the Conan dependencies for 2022 locally. I added them to CI to see if they'd work there. (They did.) Then I made this branch in the main repo so the jobs would push the dependencies to Artificatory, and downloaded them to my machine as part of my build. And that worked. So rather than wasting spending more hours debugging some obscure Conan failure, I can do more important stuff.

Type of Change

  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

Test Plan

Note that the test (Visual Studio 16 2019, Release) is required to pass by the configured branch protection rules. With this PR, that job's name will be test (Visual Studio 16 2019, windows-2019, Release). That rule will need to be bypassed and/or changed to merge this PR.

Future Tasks

Maybe get rid of 2019 entirely one of these days.

@ximinez ximinez force-pushed the ximinez/msvc22-ci branch from d8c7be4 to 46584ae Compare January 9, 2025 21:07
@ximinez ximinez changed the title DRAFT: Try MSVC 2019 and 2022(and 2025) DRAFT: Try MSVC 2019 and 2022 Jan 9, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.0%. Comparing base (5fbee8c) to head (1e5defe).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5240     +/-   ##
=========================================
- Coverage     78.0%   78.0%   -0.0%     
=========================================
  Files          789     789             
  Lines        67008   67007      -1     
  Branches      8107    8111      +4     
=========================================
- Hits         52278   52268     -10     
- Misses       14730   14739      +9     

see 2 files with indirect coverage changes

Impacted file tree graph

@ximinez ximinez changed the title DRAFT: Try MSVC 2019 and 2022 Add MSVC 2022 and debug builds to CI jobs Jan 13, 2025
@ximinez ximinez marked this pull request as ready for review January 13, 2025 21:09
@ximinez ximinez changed the title Add MSVC 2022 and debug builds to CI jobs [TRIVIAL] Add MSVC 2022 and debug builds to CI jobs Jan 13, 2025
@ximinez ximinez added CI Continuous Integration Functionality Trivial Simple change with minimal effect, or already tested. Only needs one approval. Perf impact not expected Change is not expected to improve nor harm performance. labels Jan 13, 2025
@ximinez ximinez requested a review from legleux January 13, 2025 21:22
@ximinez ximinez added this to the 2.4.0 (2025) milestone Jan 13, 2025
Copy link
Collaborator

@vlntb vlntb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@legleux legleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ximinez
Copy link
Collaborator Author

ximinez commented Jan 23, 2025

Updated suggested commit message:

chore: Update Visual Studio CI to VS 2022, and add VS Debug builds (#5240)

* Debug builds do not run tests, because they take too long.

@ximinez ximinez added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jan 23, 2025
@ximinez ximinez removed the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jan 24, 2025
@ximinez ximinez added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jan 24, 2025
@ximinez ximinez changed the title [TRIVIAL] Add MSVC 2022 and debug builds to CI jobs chore: Update Visual Studio CI to VS 2022, and add VS Debug builds Jan 24, 2025
@ximinez ximinez merged commit ed4870c into develop Jan 24, 2025
24 checks passed
@ximinez ximinez deleted the ximinez/msvc22-ci branch January 24, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Functionality Perf impact not expected Change is not expected to improve nor harm performance. Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants