-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Visual Studio CI to VS 2022, and add VS Debug builds #5240
Conversation
d8c7be4
to
46584ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5240 +/- ##
=========================================
- Coverage 78.0% 78.0% -0.0%
=========================================
Files 789 789
Lines 67008 67007 -1
Branches 8107 8111 +4
=========================================
- Hits 52278 52268 -10
- Misses 14730 14739 +9 |
8d86a99
to
88729a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Updated suggested commit message:
|
1850bb6
to
4805f47
Compare
High Level Overview of Change
Currently, we only run one CI job for Windows: MSVC 2019 Release.
This adds Debug builds, and MSVC 2022, leading to a total of 4:
Context of Change
There are two main reasons to add these builds.
wastingspending more hours debugging some obscure Conan failure, I can do more important stuff.Type of Change
.gitignore
, formatting, dropping support for older tooling)Test Plan
Note that the
test (Visual Studio 16 2019, Release)
is required to pass by the configured branch protection rules. With this PR, that job's name will betest (Visual Studio 16 2019, windows-2019, Release)
. That rule will need to be bypassed and/or changed to merge this PR.Future Tasks
Maybe get rid of 2019 entirely one of these days.