Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write proper forAllApiVersions used in NetworkOPs.cpp #4833

Merged
merged 25 commits into from
Mar 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
20a0580
Simplify setting ledger_index
Bronek Nov 30, 2023
bf3d84f
Refactor MultivarJson, implement forApiVersions
Bronek Nov 22, 2023
18ddd69
Add test for ApiVersions
Bronek Nov 29, 2023
661830c
Add constraint to visit() with tests
Bronek Nov 30, 2023
c5f9d73
Add Json-only overloads to MultivarJson visitor
Bronek Dec 1, 2023
91d3209
Allow binding rvalue MultivarJson to visitor
Bronek Dec 1, 2023
e09201d
Add RPC::apiVersion
Bronek Dec 1, 2023
c05401b
Fix comment
Bronek Dec 1, 2023
1e91f79
Add if constexpr for version dispatch
Bronek Jan 10, 2024
54e0abe
Improve MultivarJson::visitor_t overloading
Bronek Jan 10, 2024
2675f11
Removed empty requires declaration clause
Bronek Jan 18, 2024
f47a462
Merge branch 'develop' into feature/for_all_versions
Bronek Jan 23, 2024
12e266f
Merge branch 'develop' into feature/for_all_versions
Bronek Jan 31, 2024
bd9770a
Merge branch 'develop' into feature/for_all_versions
Bronek Jan 31, 2024
392f9b3
Minor improvements
Bronek Feb 1, 2024
8231028
Amend API version invariant
Bronek Feb 1, 2024
25e4627
Minor formatting
Bronek Feb 1, 2024
8f1b369
Move MultivarJson to protocol
Bronek Feb 1, 2024
e1c89d0
Split MultivarJson Policy into component parameters
Bronek Feb 1, 2024
f967972
Rename MultivarJson to MultiApiJson
Bronek Feb 2, 2024
0afad05
Rename unit tests to MultiApiJson. Add tests
Bronek Feb 2, 2024
3e4f549
Merge branch 'develop' into feature/for_all_versions
Bronek Mar 13, 2024
ab22ace
Merge branch 'develop' into feature/for_all_versions
Bronek Mar 14, 2024
712dc19
Merge branch 'develop' into feature/for_all_versions
Bronek Mar 21, 2024
6c78c73
Merge branch 'develop' into feature/for_all_versions
seelabs Mar 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'develop' into feature/for_all_versions
  • Loading branch information
Bronek committed Jan 31, 2024

Verified

This commit was signed with the committer’s verified signature.
addaleax Anna Henningsen
commit 12e266f601da19685f7769c71c931085196386dc

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.