Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporting mode always returns age in server_info. #4029

Closed
wants to merge 2 commits into from
Closed

Reporting mode always returns age in server_info. #4029

wants to merge 2 commits into from

Conversation

natenichols
Copy link
Contributor

This commit was authored by @mtrippled and has been running on reporting servers.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

@cjcobb23 cjcobb23 self-assigned this Dec 14, 2021
cjcobb23
cjcobb23 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@cjcobb23 cjcobb23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but the format check failed.

scottschurr
scottschurr approved these changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

@natenichols natenichols added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Dec 14, 2021
This was referenced Dec 15, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejohnfreeman thejohnfreeman thejohnfreeman approved these changes

@mtrippled mtrippled mtrippled approved these changes

@scottschurr scottschurr scottschurr approved these changes

@cjcobb23 cjcobb23 cjcobb23 approved these changes

Assignees

@mtrippled mtrippled

@cjcobb23 cjcobb23

Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@natenichols @thejohnfreeman @mtrippled @scottschurr @cjcobb23