Report additional fields in validation stream: #3802
Conversation
The HardenedValidations amendment introduces additional fields in validations: - `sfValidatedHash`, if present, is the hash the of last ledger that the validator considers to be fully validated. - `sfCookie`, if present, is a 64-bit cookie (the default implementation selects it randomly at startup but other implementations are possible), which can be used to improve the detection and classification of duplicate validations. - `sfServerVersion`, if present, reports the version of the software that the validator is running. By surfacing this information, server operators gain additional insight about variety of software on the network. If merged, this commit fixes #3797 by adding the fields to the `validations` stream as shown below: - `sfValidateHash` as `validated_hash`: a 256-bit hex string; - `sfCookie` as `cookie`: a 64-bit integer as a string; and - `sfServerVersion` as `server_version`: a 64-bit integer as a string.
I'll check. |
|
This pull request has been sitting for a while. The request was for unit tests, so I added to a preexisting test to see if I could un-stall the pull request: scottschurr@eeb1d41 Consider adding that unit test or something like it. You are welcome to cherry-pick that one if you'd like. The code itself looks good to me. I'll thumbs up once the test is added. |
|
I'm terribly sorry I'm not sure how a pull request was created but I didnt
submit it.
…On Wed, May 12, 2021, 12:05 PM Scott Schurr ***@***.***> wrote:
This pull request has been sitting for a while.
The request was for unit tests, so I added to a preexisting test to see if
I could un-stall the pull request: ***@***.***
<scottschurr@eeb1d41>
Consider adding that unit test or something like it. You are welcome to
cherry-pick that one if you'd like.
The code itself looks good to me. I'll thumbs up once the test is added.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3802 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANGXHFZRKLL6477GS2WHX73TNKYPHANCNFSM4Z7CMR5Q>
.
|
|
@nbougalis, this pull request has been sitting untended for close to two months. It's missing unit tests, which I believe you can cherry-pick from here: scottschurr@eeb1d41 I know that a) you're really busy, b) you're working with only one hand, and c) this pull request is not your highest priority. If you would like I can take over this pull request and shepherd it through the process so we can get this code into develop. Let me know if that would be helpful. |
|
I'm closing this pull request so I can take over shepherding it through the review process. @nbougalis, who created this pull request, is too busy to tend it right now. I'll be opening a new pull request for this code momentarily. |
The HardenedValidations amendment introduces additional fields in validations:
sfValidatedHash, if present, is the hash the of last ledger that the validator considers to be fully validated.sfCookie, if present, is a 64-bit cookie (the default implementation selects it randomly at startup but other implementations are possible), which can be used to improve the detection and classification of duplicate validations.sfServerVersion, if present, reports the version of the software that the validator is running. By surfacing this information, server operators gain additional insight about variety of software on the network.If merged, this commit fixes #3797 by adding the fields to the
validationsstream as shown below:sfValidateHashasvalidated_hash: a 256-bit hex string;sfCookieascookie: a 64-bit integer as a string; andsfServerVersionasserver_version: a 64-bit integer as a string.Type of Change
Tagging @wilsonianb's who originally opened #3797.