Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cassandra version #844

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

godexsoft
Copy link
Collaborator

@godexsoft godexsoft commented Sep 11, 2023

Fixes #843

Update cassandra-cpp-driver to latest version and remove our custom one.

@godexsoft godexsoft marked this pull request as ready for review September 11, 2023 22:00
Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . let us test it

Copy link
Collaborator

@kuznetsss kuznetsss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@godexsoft godexsoft added this to the 2.1 milestone Sep 18, 2023
@godexsoft godexsoft added the on hold For issues that currently wait on other issues label Sep 18, 2023
@godexsoft
Copy link
Collaborator Author

While this is probably alrgiht it will need some testing for us to gain confidence. Let's wait with this till after 2.0.

@godexsoft godexsoft merged commit 9bd38dd into XRPLF:develop Oct 9, 2023
kuznetsss added a commit that referenced this pull request Dec 12, 2023
@kuznetsss kuznetsss mentioned this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold For issues that currently wait on other issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cassandra-cpp-driver 2.17.0
3 participants