-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Generate config descriptions #1842
base: develop
Are you sure you want to change the base?
feat: Generate config descriptions #1842
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1842 +/- ##
===========================================
+ Coverage 71.75% 72.79% +1.04%
===========================================
Files 324 335 +11
Lines 13265 13620 +355
Branches 6742 6915 +173
===========================================
+ Hits 9518 9915 +397
+ Misses 1907 1790 -117
- Partials 1840 1915 +75 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No real blockers but a few things to consider and a few questions to answer 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Please check if we need to handle empty path input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small things can be improved 👍
Fixes #1460