fix: Optimize ledger_range query
#1797
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the very least this does not break our DB tests and i have been told that this should be a lot faster than what we had. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1797 +/- ##
========================================
Coverage 71.45% 71.45%
========================================
Files 314 314
Lines 13055 13055
Branches 6665 6665
========================================
Hits 9329 9329
Misses 1960 1960
Partials 1766 1766 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a primary key on this table,
is_latest. So there can be 0, 1, or 2 rows in this table.Adding the
inliston the primary key, scylla will hash the partition key (which is the primary key -is_latest), and only go to token ranges that match. This should be much faster than the current version.