feat: Add v3 support #1754
Merged
feat: Add v3 support #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godexsoft
commented
Nov 25, 2024
kuznetsss
reviewed
Nov 25, 2024
kuznetsss
reviewed
Nov 25, 2024
godexsoft
force-pushed
the
feature/enable-api-v3
branch
from
e981aa8 to
20c33d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1754 +/- ##
========================================
Coverage 71.65% 71.66%
========================================
Files 295 295
Lines 12652 12652
Branches 6473 6473
========================================
+ Hits 9066 9067 +1
+ Misses 1873 1871 -2
- Partials 1713 1714 +1 ☔ View full report in Codecov by Sentry. |
|
Shall we use the rippled's apiMaximumSupportedVersion in xrpl directly for max |
…o feature/enable-api-v3
@cindyyan317 I checked and I don't think we can use it. |
cindyyan317
previously approved these changes
Nov 27, 2024
kuznetsss
approved these changes
Nov 27, 2024
godexsoft
added a commit
to godexsoft/clio
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is enabling API v3 in order to support forwarding for the fix introduced in XRPLF/rippled#4924