Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support Delete NFT #1695

Merged
merged 5 commits into from
Oct 25, 2024
Merged

fix: Support Delete NFT #1695

merged 5 commits into from
Oct 25, 2024

Conversation

PeterChen13579
Copy link
Collaborator

Fixes #1677

@PeterChen13579 PeterChen13579 marked this pull request as draft October 18, 2024 19:52
@PeterChen13579 PeterChen13579 changed the title Support Delete NFT fix: Support Delete NFT Oct 18, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (cffda52) to head (064c053).
Report is 6 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1695      +/-   ##
===========================================
+ Coverage    71.69%   71.75%   +0.05%     
===========================================
  Files          276      276              
  Lines        11655    11689      +34     
  Branches      5929     5933       +4     
===========================================
+ Hits          8356     8387      +31     
- Misses        1729     1731       +2     
- Partials      1570     1571       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PeterChen13579 PeterChen13579 marked this pull request as ready for review October 21, 2024 19:15
cindyyan317
cindyyan317 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM

@PeterChen13579 PeterChen13579 merged commit d04331d into XRPLF:develop Oct 25, 2024
17 checks passed
godexsoft pushed a commit that referenced this pull request Nov 11, 2024
@PeterChen13579 @godexsoft
fix: Support Delete NFT (#1695)
081adf1 
Fixes #1677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cindyyan317 cindyyan317 cindyyan317 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support deletion of NFT Tables
2 participants
@PeterChen13579 @cindyyan317