-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor main #1555
refactor: Refactor main #1555
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1555 +/- ##
===========================================
+ Coverage 68.79% 69.19% +0.39%
===========================================
Files 239 244 +5
Lines 9677 9702 +25
Branches 5372 5384 +12
===========================================
+ Hits 6657 6713 +56
+ Misses 1624 1589 -35
- Partials 1396 1400 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. But ut is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some small things. Overall i like the changes 👍
For #442.