Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor main #1555

Merged
merged 22 commits into from
Aug 1, 2024
Merged

Conversation

kuznetsss
Copy link
Collaborator

For #442.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 51.69492% with 57 lines in your changes missing coverage. Please review.

Project coverage is 69.19%. Comparing base (fb90fb2) to head (acd966d).

Files Patch % Lines
src/app/ClioApplication.cpp 0.00% 36 Missing ⚠️
src/main/Main.cpp 0.00% 14 Missing ⚠️
src/web/Server.hpp 50.00% 0 Missing and 4 partials ⚠️
src/app/CliArgs.hpp 66.66% 1 Missing ⚠️
src/rpc/Errors.cpp 0.00% 1 Missing ⚠️
src/web/impl/HttpBase.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1555      +/-   ##
===========================================
+ Coverage    68.79%   69.19%   +0.39%     
===========================================
  Files          239      244       +5     
  Lines         9677     9702      +25     
  Branches      5372     5384      +12     
===========================================
+ Hits          6657     6713      +56     
+ Misses        1624     1589      -35     
- Partials      1396     1400       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/web/Server.cpp Outdated Show resolved Hide resolved
src/web/Server.cpp Outdated Show resolved Hide resolved
cindyyan317
cindyyan317 previously approved these changes Jul 25, 2024
Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. But ut is failing.

cindyyan317
cindyyan317 previously approved these changes Jul 30, 2024
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some small things. Overall i like the changes 👍

src/app/CMakeLists.txt Outdated Show resolved Hide resolved
src/app/ClioApplication.hpp Outdated Show resolved Hide resolved
src/util/requests/impl/SslContext.cpp Show resolved Hide resolved
src/web/Server.hpp Show resolved Hide resolved
@kuznetsss kuznetsss merged commit 2fef03d into XRPLF:develop Aug 1, 2024
26 checks passed
@kuznetsss kuznetsss deleted the 442_Refactor_main branch August 1, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants