Ledger entry type filter for account_objects and ledger_data #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cindyyan317
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1116 +/- ##
===========================================
+ Coverage 59.68% 59.74% +0.05%
===========================================
Files 207 208 +1
Lines 10478 10493 +15
Branches 5584 5589 +5
===========================================
+ Hits 6254 6269 +15
+ Misses 2637 2635 -2
- Partials 1587 1589 +2 ☔ View full report in Codecov by Sentry. |
cindyyan317
requested review from
kuznetsss and
godexsoft
and removed request for
kuznetsss
godexsoft
requested changes
Jan 17, 2024
Rename fix clang-tidy fix compilation error Fix comments
cindyyan317
force-pushed
the
ledger_object_type
branch
from
ca61d3b to
5d2449f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the ledger entry type filter for account_objects and ledger_data.
Both handlers will use the LedgerUtils functions.
Unlike transaction type, the ledger entry string which is used by filter is not exported from xrpl.
To support new ledger entry type , we need to update the LEDGER_TYPES_MAP.