Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unstable unittest #1089

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix unstable unittest #1089

merged 1 commit into from
Jan 10, 2024

Conversation

cindyyan317
Copy link
Collaborator

@cindyyan317 cindyyan317 commented Jan 9, 2024

Wait for the subthread finish to verify the result.

@cindyyan317 cindyyan317 marked this pull request as draft January 9, 2024 16:09
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61f1e08) 54.09% compared to head (1b0cef7) 54.09%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1089      +/-   ##
===========================================
- Coverage    54.09%   54.09%   -0.01%     
===========================================
  Files          203      203              
  Lines        10286    10288       +2     
  Branches      5452     5454       +2     
===========================================
+ Hits          5564     5565       +1     
  Misses        3399     3399              
- Partials      1323     1324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cindyyan317 cindyyan317 marked this pull request as ready for review January 10, 2024 11:04
@cindyyan317 cindyyan317 merged commit 2514b79 into XRPLF:develop Jan 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants