Add coverage_report target #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bronek
force-pushed
the
feature/coverage_report
branch
from
bec6ba3 to
258a07b
Compare
Bronek
force-pushed
the
feature/coverage_report
branch
10 times, most recently
from
4556636 to
388948b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1058 +/- ##
============================================
+ Coverage 34.55% 54.10% +19.55%
============================================
Files 161 187 +26
Lines 8257 9942 +1685
Branches 4851 5283 +432
============================================
+ Hits 2853 5379 +2526
- Misses 2822 3561 +739
+ Partials 2582 1002 -1580 ☔ View full report in Codecov by Sentry. |
godexsoft
reviewed
Dec 20, 2023
godexsoft
previously approved these changes
Dec 20, 2023
Bronek
force-pushed
the
feature/coverage_report
branch
from
f484c47 to
2eb9139
Compare
cindyyan317
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing the same
CodeCoverage.cmakeas in XRPLF/rippled#4849NOTE This PR should be only merged by someone with administrative access to the repo, since it makes use of
secrets.CODECOV_TOKEN. If I understand github workflows correctly, a commit (merge) made by someone without access to repo secrets would result in this change not having this access either, which will lead to spurious failures of codecov integration