Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NameGenerator into utils #876

Closed
kuznetsss opened this issue Sep 28, 2023 · 1 comment
Closed

Move NameGenerator into utils #876

kuznetsss opened this issue Sep 28, 2023 · 1 comment
Labels
good first issue Good for newcomers refactoring Code improvements without logical changes

Comments

@kuznetsss
Copy link
Collaborator

NameGenerator is duplicated in many tests. It would be better to move it into util and reuse in every test.
@kuznetsss kuznetsss added good first issue Good for newcomers refactoring Code improvements without logical changes labels Sep 28, 2023
@kuznetsss
Copy link
Collaborator Author

Also name generator can be very simple:

  [](auto const& info) { return info.param.testName; }

@PeterChen13579 PeterChen13579 mentioned this issue May 27, 2024
Merged
PeterChen13579 added a commit that referenced this issue May 29, 2024
@PeterChen13579
Move NameGenerator to util (#1428)
067dd72 
Fixes for #876
kuznetsss pushed a commit that referenced this issue Jun 18, 2024
@PeterChen13579 @kuznetsss
Move NameGenerator to util (#1428)
119b1ab 
Fixes for #876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactoring Code improvements without logical changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kuznetsss @PeterChen13579