Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For some subscribe transactions, Clio returns twice the response compared to rippled. #680

Closed
mounikakun opened this issue Jun 8, 2023 · 2 comments · Fixed by #1394
Closed
Assignees
Milestone

Comments

@mounikakun
Copy link
Collaborator

mounikakun commented Jun 8, 2023

No description provided.

@cindyyan317
Copy link
Collaborator

Should have been fixed by #672

@mounikakun Please reopen if u find other topic has this issue.

@mounikakun
Copy link
Collaborator Author

Clio is returning twice the response for accounts_proposed.

Steps to reproduce:

  • subscribe to an account on both Rippled and Clio.
  • Do a payment txn on that account and verify the subscription response

Request:

{
  "id": "Example watch Bitstamp's hot wallet",
  "command": "subscribe",
  "accounts_proposed": ["rDBDLqHwNonQDauyp7V6pCgVGHZiJAZC9S"]
}

Rippled response:

{
  "engine_result": "tesSUCCESS",
  "engine_result_code": 0,
  "engine_result_message": "The transaction was applied. Only final in a validated ledger.",
  "ledger_current_index": 5836242,
  "status": "proposed",
  "transaction": {
    "Account": "rDBDLqHwNonQDauyp7V6pCgVGHZiJAZC9S",
    "Amount": "1000000",
    "DeliverMax": "1000000",
    "Destination": "r3nyae6JUFLmZiyvropYiJQBjSTvi8H5EH",
    "Fee": "10",
    "Flags": 2147483648,
    "Sequence": 5836143,
    "SigningPubKey": "ED48970CC6D32E22A34CF41B3A7E36DB5A12382B9CEBE65C919E2B03830E3EF822",
    "TransactionType": "Payment",
    "TxnSignature": "1C401AB2908B5394C5A3F9ED7564C706FEC4D239EBFE110A82A2F08F1FD5FAB448937CE58329415EA905B8BFC8606CBDDFFE593B549BF20C0DEA08EE879F630E",
    "hash": "9CF3FF155CE3D53D1D5E23CE1526513A85EC773FF948FB350EF600DB12C0AC4D"
  },
  "type": "transaction",
  "validated": false
}{
  "close_time_iso": "2024-04-11T22:25:11Z",
  "engine_result": "tesSUCCESS",
  "engine_result_code": 0,
  "engine_result_message": "The transaction was applied. Only final in a validated ledger.",
  "ledger_hash": "672C03F67F93B6DD414D16CD2A5157BBF601CB932AB7F13E21676333411BFCA6",
  "ledger_index": 5836243,
  "meta": {
    "AffectedNodes": [
      {
        "ModifiedNode": {
          "FinalFields": {
            "Account": "r3nyae6JUFLmZiyvropYiJQBjSTvi8H5EH",
            "Balance": "10027000000",
            "Flags": 0,
            "OwnerCount": 0,
            "Sequence": 3455198
          },
          "LedgerEntryType": "AccountRoot",
          "LedgerIndex": "5A19944FEDE67BA81765525DDF1EF30CDF378B2D473F15D2B27FC16FDF493C51",
          "PreviousFields": {
            "Balance": "10026000000"
          },
          "PreviousTxnID": "E3E068696FDD47D543BC05828829BBF759B2FAD59753CC0BA920A28A74C29387",
          "PreviousTxnLgrSeq": 5836227
        }
      },
      {
        "ModifiedNode": {
          "FinalFields": {
            "Account": "rDBDLqHwNonQDauyp7V6pCgVGHZiJAZC9S",
            "Balance": "9996999970",
            "Flags": 0,
            "OwnerCount": 0,
            "Sequence": 5836144
          },
          "LedgerEntryType": "AccountRoot",
          "LedgerIndex": "D7692C5D53A33918DD998F21AD0ECD84C39F610459BA8136F7591F394040B30A",
          "PreviousFields": {
            "Balance": "9997999980",
            "Sequence": 5836143
          },
          "PreviousTxnID": "E3E068696FDD47D543BC05828829BBF759B2FAD59753CC0BA920A28A74C29387",
          "PreviousTxnLgrSeq": 5836227
        }
      }
    ],
    "TransactionIndex": 2,
    "TransactionResult": "tesSUCCESS",
    "delivered_amount": "1000000"
  },
  "status": "closed",
  "transaction": {
    "Account": "rDBDLqHwNonQDauyp7V6pCgVGHZiJAZC9S",
    "Amount": "1000000",
    "DeliverMax": "1000000",
    "Destination": "r3nyae6JUFLmZiyvropYiJQBjSTvi8H5EH",
    "Fee": "10",
    "Flags": 2147483648,
    "Sequence": 5836143,
    "SigningPubKey": "ED48970CC6D32E22A34CF41B3A7E36DB5A12382B9CEBE65C919E2B03830E3EF822",
    "TransactionType": "Payment",
    "TxnSignature": "1C401AB2908B5394C5A3F9ED7564C706FEC4D239EBFE110A82A2F08F1FD5FAB448937CE58329415EA905B8BFC8606CBDDFFE593B549BF20C0DEA08EE879F630E",
    "date": 766189511,
    "hash": "9CF3FF155CE3D53D1D5E23CE1526513A85EC773FF948FB350EF600DB12C0AC4D"
  },
  "type": "transaction",
  "validated": true
}

Clio response:

{
  "result": {
    
  },
  "id": "Example watch Bitstamp's hot wallet",
  "status": "success",
  "type": "response",
  "warnings": [
    {
      "id": 2001,
      "message": "This is a clio server. clio only serves validated data. If you want to talk to rippled, include 'ledger_index':'current' in your request"
    }
  ]
}{
  "engine_result": "tesSUCCESS",
  "engine_result_code": 0,
  "engine_result_message": "The transaction was applied. Only final in a validated ledger.",
  "ledger_current_index": 5836242,
  "status": "proposed",
  "transaction": {
    "Account": "rDBDLqHwNonQDauyp7V6pCgVGHZiJAZC9S",
    "Amount": "1000000",
    "DeliverMax": "1000000",
    "Destination": "r3nyae6JUFLmZiyvropYiJQBjSTvi8H5EH",
    "Fee": "10",
    "Flags": 2147483648,
    "Sequence": 5836143,
    "SigningPubKey": "ED48970CC6D32E22A34CF41B3A7E36DB5A12382B9CEBE65C919E2B03830E3EF822",
    "TransactionType": "Payment",
    "TxnSignature": "1C401AB2908B5394C5A3F9ED7564C706FEC4D239EBFE110A82A2F08F1FD5FAB448937CE58329415EA905B8BFC8606CBDDFFE593B549BF20C0DEA08EE879F630E",
    "hash": "9CF3FF155CE3D53D1D5E23CE1526513A85EC773FF948FB350EF600DB12C0AC4D"
  },
  "type": "transaction",
  "validated": false
}{
  "engine_result": "tesSUCCESS",
  "engine_result_code": 0,
  "engine_result_message": "The transaction was applied. Only final in a validated ledger.",
  "ledger_current_index": 5836242,
  "status": "proposed",
  "transaction": {
    "Account": "rDBDLqHwNonQDauyp7V6pCgVGHZiJAZC9S",
    "Amount": "1000000",
    "DeliverMax": "1000000",
    "Destination": "r3nyae6JUFLmZiyvropYiJQBjSTvi8H5EH",
    "Fee": "10",
    "Flags": 2147483648,
    "Sequence": 5836143,
    "SigningPubKey": "ED48970CC6D32E22A34CF41B3A7E36DB5A12382B9CEBE65C919E2B03830E3EF822",
    "TransactionType": "Payment",
    "TxnSignature": "1C401AB2908B5394C5A3F9ED7564C706FEC4D239EBFE110A82A2F08F1FD5FAB448937CE58329415EA905B8BFC8606CBDDFFE593B549BF20C0DEA08EE879F630E",
    "hash": "9CF3FF155CE3D53D1D5E23CE1526513A85EC773FF948FB350EF600DB12C0AC4D"
  },
  "type": "transaction",
  "validated": false
}{
  "close_time_iso": "2024-04-11T22:25:11Z",
  "engine_result": "tesSUCCESS",
  "engine_result_code": 0,
  "engine_result_message": "The transaction was applied. Only final in a validated ledger.",
  "ledger_hash": "672C03F67F93B6DD414D16CD2A5157BBF601CB932AB7F13E21676333411BFCA6",
  "ledger_index": 5836243,
  "meta": {
    "AffectedNodes": [
      {
        "ModifiedNode": {
          "FinalFields": {
            "Account": "r3nyae6JUFLmZiyvropYiJQBjSTvi8H5EH",
            "Balance": "10027000000",
            "Flags": 0,
            "OwnerCount": 0,
            "Sequence": 3455198
          },
          "LedgerEntryType": "AccountRoot",
          "LedgerIndex": "5A19944FEDE67BA81765525DDF1EF30CDF378B2D473F15D2B27FC16FDF493C51",
          "PreviousFields": {
            "Balance": "10026000000"
          },
          "PreviousTxnID": "E3E068696FDD47D543BC05828829BBF759B2FAD59753CC0BA920A28A74C29387",
          "PreviousTxnLgrSeq": 5836227
        }
      },
      {
        "ModifiedNode": {
          "FinalFields": {
            "Account": "rDBDLqHwNonQDauyp7V6pCgVGHZiJAZC9S",
            "Balance": "9996999970",
            "Flags": 0,
            "OwnerCount": 0,
            "Sequence": 5836144
          },
          "LedgerEntryType": "AccountRoot",
          "LedgerIndex": "D7692C5D53A33918DD998F21AD0ECD84C39F610459BA8136F7591F394040B30A",
          "PreviousFields": {
            "Balance": "9997999980",
            "Sequence": 5836143
          },
          "PreviousTxnID": "E3E068696FDD47D543BC05828829BBF759B2FAD59753CC0BA920A28A74C29387",
          "PreviousTxnLgrSeq": 5836227
        }
      }
    ],
    "TransactionIndex": 2,
    "TransactionResult": "tesSUCCESS",
    "delivered_amount": "1000000"
  },
  "status": "closed",
  "transaction": {
    "Account": "rDBDLqHwNonQDauyp7V6pCgVGHZiJAZC9S",
    "Amount": "1000000",
    "DeliverMax": "1000000",
    "Destination": "r3nyae6JUFLmZiyvropYiJQBjSTvi8H5EH",
    "Fee": "10",
    "Flags": 2147483648,
    "Sequence": 5836143,
    "SigningPubKey": "ED48970CC6D32E22A34CF41B3A7E36DB5A12382B9CEBE65C919E2B03830E3EF822",
    "TransactionType": "Payment",
    "TxnSignature": "1C401AB2908B5394C5A3F9ED7564C706FEC4D239EBFE110A82A2F08F1FD5FAB448937CE58329415EA905B8BFC8606CBDDFFE593B549BF20C0DEA08EE879F630E",
    "date": 766189511,
    "hash": "9CF3FF155CE3D53D1D5E23CE1526513A85EC773FF948FB350EF600DB12C0AC4D"
  },
  "type": "transaction",
  "validated": true
}{
  "close_time_iso": "2024-04-11T22:25:11Z",
  "engine_result": "tesSUCCESS",
  "engine_result_code": 0,
  "engine_result_message": "The transaction was applied. Only final in a validated ledger.",
  "ledger_hash": "672C03F67F93B6DD414D16CD2A5157BBF601CB932AB7F13E21676333411BFCA6",
  "ledger_index": 5836243,
  "meta": {
    "AffectedNodes": [
      {
        "ModifiedNode": {
          "FinalFields": {
            "Account": "r3nyae6JUFLmZiyvropYiJQBjSTvi8H5EH",
            "Balance": "10027000000",
            "Flags": 0,
            "OwnerCount": 0,
            "Sequence": 3455198
          },
          "LedgerEntryType": "AccountRoot",
          "LedgerIndex": "5A19944FEDE67BA81765525DDF1EF30CDF378B2D473F15D2B27FC16FDF493C51",
          "PreviousFields": {
            "Balance": "10026000000"
          },
          "PreviousTxnID": "E3E068696FDD47D543BC05828829BBF759B2FAD59753CC0BA920A28A74C29387",
          "PreviousTxnLgrSeq": 5836227
        }
      },
      {
        "ModifiedNode": {
          "FinalFields": {
            "Account": "rDBDLqHwNonQDauyp7V6pCgVGHZiJAZC9S",
            "Balance": "9996999970",
            "Flags": 0,
            "OwnerCount": 0,
            "Sequence": 5836144
          },
          "LedgerEntryType": "AccountRoot",
          "LedgerIndex": "D7692C5D53A33918DD998F21AD0ECD84C39F610459BA8136F7591F394040B30A",
          "PreviousFields": {
            "Balance": "9997999980",
            "Sequence": 5836143
          },
          "PreviousTxnID": "E3E068696FDD47D543BC05828829BBF759B2FAD59753CC0BA920A28A74C29387",
          "PreviousTxnLgrSeq": 5836227
        }
      }
    ],
    "TransactionIndex": 2,
    "TransactionResult": "tesSUCCESS",
    "delivered_amount": "1000000"
  },
  "status": "closed",
  "transaction": {
    "Account": "rDBDLqHwNonQDauyp7V6pCgVGHZiJAZC9S",
    "Amount": "1000000",
    "DeliverMax": "1000000",
    "Destination": "r3nyae6JUFLmZiyvropYiJQBjSTvi8H5EH",
    "Fee": "10",
    "Flags": 2147483648,
    "Sequence": 5836143,
    "SigningPubKey": "ED48970CC6D32E22A34CF41B3A7E36DB5A12382B9CEBE65C919E2B03830E3EF822",
    "TransactionType": "Payment",
    "TxnSignature": "1C401AB2908B5394C5A3F9ED7564C706FEC4D239EBFE110A82A2F08F1FD5FAB448937CE58329415EA905B8BFC8606CBDDFFE593B549BF20C0DEA08EE879F630E",
    "date": 766189511,
    "hash": "9CF3FF155CE3D53D1D5E23CE1526513A85EC773FF948FB350EF600DB12C0AC4D"
  },
  "type": "transaction",
  "validated": true
}

@mounikakun mounikakun reopened this Apr 11, 2024
@kuznetsss kuznetsss self-assigned this Apr 24, 2024
@kuznetsss kuznetsss added this to the 2.2 milestone Apr 24, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Apr 24, 2024
@kuznetsss kuznetsss removed this from Clio Apr 24, 2024
@kuznetsss kuznetsss added this to Clio Apr 24, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Apr 24, 2024
@kuznetsss kuznetsss moved this from 📋 Backlog to 🏗 In progress in Clio Apr 24, 2024
kuznetsss added a commit that referenced this issue May 15, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Merged in Clio May 15, 2024
kuznetsss added a commit that referenced this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Merged
Development

Successfully merging a pull request may close this issue.

3 participants