Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0079 Python Code Samples 2 #78

Merged
merged 7 commits into from
Jan 19, 2023
Merged

0079 Python Code Samples 2 #78

merged 7 commits into from
Jan 19, 2023

Conversation

pdp2121
Copy link
Collaborator

@pdp2121 pdp2121 commented Dec 22, 2022

Submitting a bounty to add more code samples to capture more common tasks in Python.

@pdp2121 pdp2121 changed the title Python Code Sample 2 0079 Python Code Samples 2 Dec 22, 2022
| # | Description | Details | Proposed Potential Award | Open? |
| --- | ------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------ | ----- |
| 1 | NFT | Mint (or batch mint) and burn an [NFT Token](https://xrpl.org/non-fungible-tokens.html#non-fungible-tokens-overview), assign an authorized minter, transfer NFT tokens (create, cancel, and accept offer). | $1000 | Open |
| 2 | Require Destination Tags | Enable [Require Destionation Tags](https://xrpl.org/require-destination-tags.html#require-destination-tags) for an account. | $500 | Open |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is for xrpl.org only we can remove Use Tickets, Escrow History, and Tickets should be removed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Tickets exists on xrpl.org for Python (List which Tickets are outstanding against one’s own account and use Tickets to collect signatures for multisign transactions)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tickets does

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this bounty was for updating the code in guides. Do we need to update the description of the bounty then?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah description could be more clear

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but that's for use-tickets, Tickets have a different description - List which Tickets are outstanding against one’s own account and use Tickets to collect signatures for multisign transactions.


| # | Description | Details | Proposed Potential Award | Open? |
| --- | ------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------ | ----- |
| 1 | NFT | Mint (or batch mint) and burn an [NFT Token](https://xrpl.org/non-fungible-tokens.html#non-fungible-tokens-overview), assign an authorized minter, transfer NFT tokens (create, cancel, and accept offer). | $1000 | Open |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a higher amount because this is essentially the same amount of code as our javascript quickstart guide.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1500 seems reasonable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ye, 1500-2000 is reasonable.

@jonathanlei jonathanlei requested a review from ckniffen January 18, 2023 23:39
@jonathanlei jonathanlei merged commit 5989a5b into main Jan 19, 2023
@jonathanlei jonathanlei deleted the py-code-sample2 branch January 19, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants