-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added select_one_from file and select_multiple_from_file, close #164 #171
Conversation
I feel like we should at least make some attempt of acknowledging that there's a connection between this and the external XML data section and contrasting it with the "Dynamic selects from pre-loaded data" and "External selects" sections. What do you think? |
Yes, and vice versa. Good point. Will try something and steer users to these 'proper XForm' solutions if they work for them. |
Forgot to commit this work. Let me know what you think (though no hurry)! |
Sorry about letting this sit. I have all kinds of thoughts. Would you be up for a 30min call to discuss? I think that might be more efficient than going back and forth as I have a number of questions for you about Enketo performance and external datasets in general. Let me know if so and I'll reach out to schedule. |
Thanks, yes, I will ping you in the next few days to find a time. Now getting ready to battle a snow storm (and play in the snow). |
I know! 😫
Hard to imagine from here -- "we put the 'sweat' in 'sweater weather'" at highs in the 90Fs this week. Hope it all goes well and that there's some fun to be had! ❄️ |
I am quite curious now to try to load a form in Enketo with hundreds of thousand of data items that provides the rationale for select_external in ODK Collect. Do you perhaps have a real-life form for which select_external is required? If it does load well (who knows, but probably not), it's worth exploring a transformation of select_external in enketo-transformer into regular external CSV data syntax (with a workaround for translations). |
nigeria_wards_internal_simplified.xml.zip is an example we discussed privately with ~10k items. This kind of form was the rationale for the features originally. It now performs reasonably well on modern devices and with performance improvements made over the last couple of years. Sadly, it doesn't look like there was any attempt to speed up the spec-compliant implementation before adding the database-backed implementations. Unfortunately, I don't have access to real data that gets to larger scales. I'll see if I can get my hands on some or find a real deployment whose data we can mimic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this. I expect there will be some confusion because it comes before the other options but it's probably not a big deal and we can adjust as needed.
_sections/home-english.md
Outdated
|
||
| type | name | label | choice_filter | | ||
| --------------------------------------- | ---- | ------------------------------ | --------------- | | ||
| select_multiple_from_file country.csv | dest | Which countries did you live? | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be "In which countries did you live?" or "Which countries did you live in?". Does dest
make sense as a name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Will change! Thx
_sections/home-english.md
Outdated
| type | name | label | choice_filter | | ||
| --------------------------------------- | ---- | ------------------------------ | --------------- | | ||
| select_multiple_from_file country.csv | dest | Which countries did you live? | | | ||
| select_one_from_file countries.xml | cou | Which country do you live now? | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above -- "In which country do you live now?" or "Which country do you live in now?"
Oh, that's great. I misunderstood you during our last meeting. So the path is open to promoting these new spec-compliant ways. |
Yes, I agree, external data is messy, reflecting implementations ;). Indeed, we can improve it later. |
I think so? Like you, I think I need to see examples of truly large datasets to see how they're performing these days. I think another thing that's missing is documentation on the full workflow from "I have a CSV that was created by some other process" to "my form definition queries that data and uses it in selects". It's unfortunate that columns named For the actual querying, I go back and forth on how that's best done. As much as I don't love |
No description provided.