Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should not add default hints into forms #67

Merged
merged 1 commit into from
May 23, 2016
Merged

We should not add default hints into forms #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions pyxform/question_type_dictionary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,26 +381,23 @@ def generate_new_dict():
},
"bind": {
"type": "geopoint"
},
"hint": "GPS coordinates can only be collected when outside."
}
},
"geoshape": {
"control": {
"tag": "input"
},
"bind": {
"type": "geoshape"
},
"hint": "GPS coordinates can only be collected when outside."
}
},
"geotrace": {
"control": {
"tag": "input"
},
"bind": {
"type": "geotrace"
},
"hint": "GPS coordinates can only be collected when outside."
}
},
"select multiple from": {
"control": {
Expand Down Expand Up @@ -542,8 +539,7 @@ def generate_new_dict():
},
"bind": {
"type": "geopoint"
},
"hint": "GPS coordinates can only be collected when outside."
}
},
"q date": {
"control": {
Expand Down
1 change: 0 additions & 1 deletion pyxform/tests/example_xls/spec_test_expected_output.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,6 @@
</input>
<input ref="/xlsform_spec_test/everything/geopoint_test">
<label ref="jr:itext('/xlsform_spec_test/everything/geopoint_test:label')"/>
<hint>GPS coordinates can only be collected when outside.</hint>
</input>
<input ref="/xlsform_spec_test/everything/barcode_test">
<label ref="jr:itext('/xlsform_spec_test/everything/barcode_test:label')"/>
Expand Down
1 change: 0 additions & 1 deletion pyxform/tests/test_expected_output/attribute_columns_test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,6 @@
</input>
<input bodyAttribute="test" bodyAttribute2="test" ref="/attribute_columns_test/everything/geopoint_test">
<label ref="jr:itext('/attribute_columns_test/everything/geopoint_test:label')"/>
<hint>GPS coordinates can only be collected when outside.</hint>
</input>
<input bodyAttribute="test" bodyAttribute2="test" ref="/attribute_columns_test/everything/barcode_test">
<label ref="jr:itext('/attribute_columns_test/everything/barcode_test:label')"/>
Expand Down
1 change: 0 additions & 1 deletion pyxform/tests/test_expected_output/flat_xlsform_test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,6 @@
</input>
<input ref="/flat_xlsform_test/geopoint_test">
<label ref="jr:itext('/flat_xlsform_test/geopoint_test:label')"/>
<hint>GPS coordinates can only be collected when outside.</hint>
</input>
<input ref="/flat_xlsform_test/barcode_test">
<label ref="jr:itext('/flat_xlsform_test/barcode_test:label')"/>
Expand Down
1 change: 0 additions & 1 deletion pyxform/tests/test_expected_output/xlsform_spec_test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,6 @@
</input>
<input ref="/xlsform_spec_test/everything/geopoint_test">
<label ref="jr:itext('/xlsform_spec_test/everything/geopoint_test:label')"/>
<hint>GPS coordinates can only be collected when outside.</hint>
</input>
<input ref="/xlsform_spec_test/everything/barcode_test">
<label ref="jr:itext('/xlsform_spec_test/everything/barcode_test:label')"/>
Expand Down
1 change: 0 additions & 1 deletion pyxform/tests/test_output/attribute_columns_test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,6 @@
</input>
<input bodyAttribute="test" bodyAttribute2="test" ref="/attribute_columns_test/everything/geopoint_test">
<label ref="jr:itext('/attribute_columns_test/everything/geopoint_test:label')"/>
<hint>GPS coordinates can only be collected when outside.</hint>
</input>
<input bodyAttribute="test" bodyAttribute2="test" ref="/attribute_columns_test/everything/barcode_test">
<label ref="jr:itext('/attribute_columns_test/everything/barcode_test:label')"/>
Expand Down
1 change: 0 additions & 1 deletion pyxform/tests/test_output/flat_xlsform_test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,6 @@
</input>
<input ref="/flat_xlsform_test/geopoint_test">
<label ref="jr:itext('/flat_xlsform_test/geopoint_test:label')"/>
<hint>GPS coordinates can only be collected when outside.</hint>
</input>
<input ref="/flat_xlsform_test/barcode_test">
<label ref="jr:itext('/flat_xlsform_test/barcode_test:label')"/>
Expand Down
1 change: 0 additions & 1 deletion pyxform/tests/test_output/xlsform_spec_test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,6 @@
</input>
<input ref="/xlsform_spec_test/everything/geopoint_test">
<label ref="jr:itext('/xlsform_spec_test/everything/geopoint_test:label')"/>
<hint>GPS coordinates can only be collected when outside.</hint>
</input>
<input ref="/xlsform_spec_test/everything/barcode_test">
<label ref="jr:itext('/xlsform_spec_test/everything/barcode_test:label')"/>
Expand Down