Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #87 validation of external instances #104

Merged
merged 2 commits into from
Mar 29, 2017

Conversation

rhunwicks
Copy link
Contributor

No description provided.

@ukanga
Copy link
Contributor

ukanga commented Mar 28, 2017

Looks okay, any chance you can add a test for this?

@rhunwicks
Copy link
Contributor Author

rhunwicks commented Mar 29, 2017

I have added run_odk_validate=True to the existing tests, which causes them to fail against master. Then I have updated them to match the slightly altered XML output (with the included _) such that they pass in this branch.

@ukanga ukanga merged commit df76208 into XLSForm:master Mar 29, 2017
@MartijnR
Copy link
Contributor

MartijnR commented Mar 29, 2017

Thanks @rhunwicks. This is great.

External instances have been accepted by the ODK community recently, so hopefully after a future ODK Validate update, we should be able to remove the trick (the complete dummy instance content) that fools it into validating.

@rhunwicks rhunwicks deleted the 87-external-instances-validation branch March 30, 2017 23:02
@rhunwicks
Copy link
Contributor Author

@MartijnR please can you point me to the discussion about accepting external instances - I want to use select_one_from_file with Kobocat and there are some changes to Kobocat that would be required?

@dorey
Copy link
Contributor

dorey commented Mar 31, 2017

@rhunwicks, in one of the kobocat py files (I can't look it up right now) there's a method imported called from pyxform import survey_from. If you comment out this import , then you can switch kobocat's pyxform to this one, and only lose spss features. We are working on a fix to kobocat's pyxform situation that should be pushed in the next week, at which point select_one_from_file will be supported.

@MartijnR
Copy link
Contributor

Excellent news @dorey (probably also activates pulldata())

@rhunwicks the discussion I was referring to in order to in the future clean up the pyxform code by removing th dummy instance content was an XForms Spec discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants