Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP-Secure tunnelling support #875

Closed
wants to merge 8 commits into from
Closed

Conversation

farmio
Copy link
Member

@farmio farmio commented Feb 20, 2022

Description

Add IP-Secure tunnelling support.

This is work in progress:

  • add necessary Frame parsers
  • add parsing and decryption of knxkeys files
  • verify knxkeys file with signature before using it
  • add SearchRequestExtended support (not sure if this is needed yet)
  • add SecureSession class (between Interface and Transport)
  • add configuration options for needed parameters (passwords / keys)
  • properly initiate SecureSession and keep it alive
  • decrypt, verify and handle various encrypted KNXnet/IP frames
  • properly react to various SessionStatus indications
  • add tests... lots of tests

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #875 (7a6db12) into main (fc71b01) will decrease coverage by 0.06%.
The diff coverage is 92.59%.

❗ Current head 7a6db12 differs from pull request most recent head 0d05e9c. Consider uploading reports for the commit 0d05e9c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   95.50%   95.44%   -0.07%     
==========================================
  Files         116      121       +5     
  Lines        7013     7175     +162     
==========================================
+ Hits         6698     6848     +150     
- Misses        315      327      +12     
Impacted Files Coverage Δ
xknx/knxip/session_status.py 84.00% <84.00%> (ø)
xknx/knxip/session_authenticate.py 91.66% <91.66%> (ø)
xknx/knxip/session_request.py 92.00% <92.00%> (ø)
xknx/knxip/session_response.py 92.30% <92.30%> (ø)
xknx/knxip/secure_wrapper.py 94.28% <94.28%> (ø)
xknx/knxip/__init__.py 100.00% <100.00%> (ø)
xknx/knxip/knxip.py 100.00% <100.00%> (ø)
xknx/knxip/knxip_enum.py 100.00% <100.00%> (ø)

@farmio
Copy link
Member Author

farmio commented Feb 28, 2022

superseded by #879 to use a feature branch https://github.com/XKNX/xknx/tree/ip-secure

@farmio farmio closed this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant