Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lint, sort, format, repeat #33

Merged
merged 8 commits into from
Mar 30, 2023
Merged

chore: lint, sort, format, repeat #33

merged 8 commits into from
Mar 30, 2023

Conversation

farmio
Copy link
Member

@farmio farmio commented Mar 22, 2023

  • Removed some unused imports.
  • use nothing when returning empty template.
  • use !== instead of !=
  • Sort imports, add empty line between lit, ha and knx imports.

@farmio farmio requested a review from marvin-w March 22, 2023 07:31
@marvin-w
Copy link
Member

Adding a linter to github actions might be a good addition to this

@farmio
Copy link
Member Author

farmio commented Mar 23, 2023

Maybe we should even add pre-commit. But that should be an extra PR imho.

farmio
farmio commented Mar 23, 2023
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
marvin-w
marvin-w approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good from what I see.

@marvin-w marvin-w merged commit 80a5ede into main Mar 30, 2023
@marvin-w marvin-w deleted the eslint branch March 30, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvin-w marvin-w marvin-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farmio @marvin-w