Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected code to account for new lodestone layout #19

Merged
merged 1 commit into from
Apr 1, 2017
Merged

Corrected code to account for new lodestone layout #19

merged 1 commit into from
Apr 1, 2017

Conversation

ReidWeb
Copy link
Member

@ReidWeb ReidWeb commented Mar 31, 2017

Resolves #18

@ReidWeb ReidWeb requested a review from Pricetx March 31, 2017 22:31
@ReidWeb ReidWeb added the bug label Mar 31, 2017
@codecov
Copy link

codecov bot commented Mar 31, 2017

Codecov Report

Merging #19 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   93.24%   93.47%   +0.23%     
==========================================
  Files           4        4              
  Lines        1036     1027       -9     
  Branches      113      110       -3     
==========================================
- Hits          966      960       -6     
  Misses         54       54              
+ Partials       16       13       -3
Impacted Files Coverage Δ
src/main/java/com/ffxivcensus/gatherer/Player.java 97.18% <100%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 823f097...391482b. Read the comment docs.

Pricetx
Pricetx approved these changes Apr 1, 2017
View reviewed changes
Copy link
Member

@Pricetx Pricetx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be passing unit tests again. Approved.

@Pricetx Pricetx merged commit 2262768 into master Apr 1, 2017
@ReidWeb ReidWeb deleted the bugfix/issue-18 branch April 19, 2017 17:55
ReidWeb added a commit that referenced this pull request Aug 23, 2017
@ReidWeb
Merge branch '19_stormblood' of github.com:matthewhillier/XIVStats-Ga…
d0c4eab 
…therer-Java into pr-test-pr

* '19_stormblood' of github.com:matthewhillier/XIVStats-Gatherer-Java:
  Update README.md
  Update README.md
  #19 Corrected missing comma
  #19 Added missing carpenter field
  #19 Added level fields for Scholar, Red Mage and Samurai
  #19 Added Table fields and mappings for Stormblood progression
  #19 Added in completion stats for Stormblood & Corrected parameter ordering in the getPlayerTest
  #19 Updated Player Unit Test
  #19 Added Omega & Louisoix servers
  #19 Adding in variables for Scholar, Red Mage and Samurai and updating the parse order to match the Lodestone update
  Update README.md (#22)
  Remove un-necessary print statement (#20)
  Corrected code to account for new lodestone layout (#19)
ReidWeb pushed a commit that referenced this pull request Aug 26, 2017
@matthewhillier @ReidWeb
#19 Adding in variables for Scholar, Red Mage and Samurai and updatin…
9062cee 
…g the parse order to match the Lodestone update
ReidWeb pushed a commit that referenced this pull request Aug 26, 2017
@matthewhillier @ReidWeb
#19 Added Omega & Louisoix servers
b9bda39
ReidWeb pushed a commit that referenced this pull request Aug 26, 2017
@matthewhillier @ReidWeb
#19 Updated Player Unit Test
d9f6625
ReidWeb pushed a commit that referenced this pull request Aug 26, 2017
@matthewhillier @ReidWeb
#19 Added in completion stats for Stormblood & Corrected parameter or…
ff994c5 
…dering in the getPlayerTest

NOTE: SB completion is currently opaque as the MSQ final quest doesn't drop anything. Implemeted a best-guess based on end-game content drops.
ReidWeb pushed a commit that referenced this pull request Aug 26, 2017
@matthewhillier @ReidWeb
#19 Added Table fields and mappings for Stormblood progression
a528d26
ReidWeb pushed a commit that referenced this pull request Aug 26, 2017
@matthewhillier @ReidWeb
#19 Added level fields for Scholar, Red Mage and Samurai
41fd317
ReidWeb pushed a commit that referenced this pull request Aug 26, 2017
@matthewhillier @ReidWeb
#19 Added missing carpenter field
3ff510e
ReidWeb pushed a commit that referenced this pull request Aug 26, 2017
@matthewhillier @ReidWeb
#19 Corrected missing comma
8a4d41a
Graphicscore pushed a commit to Graphicscore/XIVStats-Gatherer-Java that referenced this pull request Jul 29, 2021
@ReidWeb @Pricetx
Corrected code to account for new lodestone layout (XIVStats#19)
2842021
Graphicscore pushed a commit to Graphicscore/XIVStats-Gatherer-Java that referenced this pull request Jul 29, 2021
@matthewhillier @ReidWeb
XIVStats#19 Adding in variables for Scholar, Red Mage and Samurai and…
4edeb91 
… updating the parse order to match the Lodestone update
Graphicscore pushed a commit to Graphicscore/XIVStats-Gatherer-Java that referenced this pull request Jul 29, 2021
@matthewhillier @ReidWeb
XIVStats#19 Added Omega & Louisoix servers
4e97ef5
Graphicscore pushed a commit to Graphicscore/XIVStats-Gatherer-Java that referenced this pull request Jul 29, 2021
@matthewhillier @ReidWeb
XIVStats#19 Updated Player Unit Test
e91294e
Graphicscore pushed a commit to Graphicscore/XIVStats-Gatherer-Java that referenced this pull request Jul 29, 2021
@matthewhillier @ReidWeb
XIVStats#19 Added in completion stats for Stormblood & Corrected para…
56c3707 
…meter ordering in the getPlayerTest

NOTE: SB completion is currently opaque as the MSQ final quest doesn't drop anything. Implemeted a best-guess based on end-game content drops.
Graphicscore pushed a commit to Graphicscore/XIVStats-Gatherer-Java that referenced this pull request Jul 29, 2021
@matthewhillier @ReidWeb
XIVStats#19 Added Table fields and mappings for Stormblood progression
3eea3e1
Graphicscore pushed a commit to Graphicscore/XIVStats-Gatherer-Java that referenced this pull request Jul 29, 2021
@matthewhillier @ReidWeb
XIVStats#19 Added level fields for Scholar, Red Mage and Samurai
43b895c
Graphicscore pushed a commit to Graphicscore/XIVStats-Gatherer-Java that referenced this pull request Jul 29, 2021
@matthewhillier @ReidWeb
XIVStats#19 Added missing carpenter field
48c7d7f
Graphicscore pushed a commit to Graphicscore/XIVStats-Gatherer-Java that referenced this pull request Jul 29, 2021
@matthewhillier @ReidWeb
XIVStats#19 Corrected missing comma
00432d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pricetx Pricetx Pricetx approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReidWeb @Pricetx