Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/secure cookie #1285

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Fix/secure cookie #1285

merged 2 commits into from
Jul 31, 2024

Conversation

jenbutongit
Copy link
Contributor

@jenbutongit jenbutongit commented Jul 31, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please also include any acceptance criteria if you have any.

  • Correctly set isSecure on the session cookie
  • Fix auth test which relied on removing secure; HttpOnly (since the cookie now correctly does not have the secure; flag)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.

  • Fix unit tests
  • Local check on cookies

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • I have updated the architecture diagrams as per Contribute.md OR added an architectural decision record entry

@jenbutongit jenbutongit merged commit ee316e4 into main Jul 31, 2024
24 checks passed
@jenbutongit jenbutongit deleted the fix/secure-cookie branch July 31, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants