Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated confirmation page template layout #1170

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

ziggy-cyb
Copy link
Collaborator

Description

the layout for the confirmation page has changed in the GOV.UK design system, so this PR will change the layout of our confirmation page so that it matches.

  • confirmationPage.customText.nextSteps will now appear above the "what happens next" title
  • "What happens next" title will now only show if there are components underneath it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual testing with different form jsons (attached)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • I have updated the architecture diagrams as per Contribute.md OR added an architectural decision record entry

form-with-components.json
form-with-next-steps.json
form-without-next-steps.json

@ziggy-cyb ziggy-cyb changed the title Updated confirmation page template layout fix: Updated confirmation page template layout Dec 4, 2023
@jenbutongit jenbutongit self-requested a review December 5, 2023 14:39
@ziggy-cyb ziggy-cyb merged commit b7fb288 into main Dec 6, 2023
12 checks passed
@ziggy-cyb ziggy-cyb deleted the fix/confirmation-page-layout branch December 6, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants