Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be compatible with new Plugin.run_id #1410

Merged
merged 4 commits into from
Aug 25, 2024
Merged

Be compatible with new Plugin.run_id #1410

merged 4 commits into from
Aug 25, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Aug 25, 2024

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Following AxFoundation/strax#871 and AxFoundation/strax#879. Just a minor change.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx marked this pull request as ready for review August 25, 2024 05:30
@coveralls
Copy link

Coverage Status

coverage: 91.156% (+0.02%) from 91.135%
when pulling 7b01948 on new_run_id
into dd9f866 on master.

@dachengx dachengx merged commit 3e48a58 into master Aug 25, 2024
8 checks passed
@dachengx dachengx deleted the new_run_id branch August 25, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants