Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit DEFAULT_CHUNK_SPLIT_NS from strax #1405

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Aug 9, 2024

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

Depends on AxFoundation/strax#865, where the minimum allowed splitting of chunk is DEFAULT_CHUNK_SPLIT_NS. This PR also temporarily uses the latest strax to be compatible with the latest codes.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx changed the title Inherit DEFAULT_CHUNK_SPLIT_NS from strax Inherit DEFAULT_CHUNK_SPLIT_NS from strax Aug 9, 2024
@coveralls
Copy link

coveralls commented Aug 17, 2024

Coverage Status

coverage: 91.156% (+0.02%) from 91.135%
when pulling 77b0de3 on inherit_safe_break_in_pulses
into 5622027 on master.

@dachengx dachengx marked this pull request as ready for review August 17, 2024 16:56
@dachengx dachengx merged commit 419f06c into master Aug 17, 2024
6 of 8 checks passed
@dachengx dachengx deleted the inherit_safe_break_in_pulses branch August 17, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants