Add pad-array protocol #1266
Merged
Add pad-array protocol #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tests/test_url_config.py
Outdated
| @@ -391,3 +391,10 @@ def test_run_doc_protocol(self): | |||
| self.st.set_config({ 'test_config': "run_doc://mode?run_id=plugin.run_id" }) | |||
| p = self.st.get_single_plugin(999999999, 'test_data') | |||
| return p.test_config | |||
|
|
|||
| def test_pad_array(self): | |||
| self.st.set_config({'test_config': 'pad-array://json://[1,2,3]?pad_left=2&pad_right=3&pad_value=0'}) | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
E501 line too long (108 > 100 characters)
|
Looks good. Thanks for the quick implementation. |
WenzDaniel
previously approved these changes
Sep 18, 2023
|
I was trying to test this protocol but I am a bit confused as to why it is in the xe1t_url_config and not in the normal url_config file, is there something I am missing here? |
|
I successfully used the protocol to process some nv records so this is ready to be merged |
|
@LuisSanchez25 If you tested this, can you add your review? thanks. |
LuisSanchez25
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a URLConfig protocol wich will pad an array on the left or right or both with a configurable number of elements of the specified value
The protocol accepts the arguments pad_left, pad_right and pad_value to specify how many elements to add and what value to fill them with.