Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ipython version and add comm dependency #1293

Merged
merged 4 commits into from
Apr 29, 2023
Merged

Fix ipython version and add comm dependency #1293

merged 4 commits into from
Apr 29, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Apr 29, 2023 •
edited
Loading

From ipython==8.13.0, it stops supporting python==3.8 or lower versions.

https://github.com/ipython/ipython/blob/02bab11e7a2cd15670c17f6c8587f0609eb61961/IPython/__init__.py#L29

@dachengx
Copy link
Collaborator Author

Following ipython/comm#13

@dachengx dachengx changed the title Fix ipython version Fix ipython version and add comm dependency Apr 29, 2023
@dachengx dachengx mentioned this pull request Apr 29, 2023
Merged
jmosbacher
jmosbacher approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@jmosbacher jmosbacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dachengx

@jmosbacher jmosbacher merged commit e4134b2 into master Apr 29, 2023
@dachengx dachengx deleted the fix_ipython branch April 29, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmosbacher jmosbacher jmosbacher approved these changes

@FaroutYLq FaroutYLq Awaiting requested review from FaroutYLq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachengx @jmosbacher