only check tools name from shebang/env #1200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1198
This is my first time to write rust code, any comments are welcome.
The original solution is to compare the whole path of shebang line, but the path might be different even for the same tool.
This only check the last word of the application, and check it twice.
The 1st time is do exactly match, then 2nd time to starts_with match.
The starts_with match might match python_abc for Python, but original solution already have that issue for the env check.
The commit also made changes to the languages.json, it remove all the path from shebangs line, and remove all env lines as it not required anymore. Also I made a few changes to the languages definition.
Thanks for your time.