Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets and Code scanning alerts API #730

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

vlad1slav
Copy link
Contributor

APIs from #549 and #526:
/repos/{owner}/{repo}/secret-scanning/alerts
/repos/{owner}/{repo}/code-scanning/alerts
/repos/{owner}/{repo}/code-scanning/alerts/{alert_number}

@vlad1slav
Copy link
Contributor Author

@XAMPPRocky, I have questions about the src/models/code_scannings.rs file, don't know if the code in question had some logic behind it, I've added comments to the lines in question, but here is the summary:

  • struct Dismisser looks like a SimpleUser, so maybe it should be removed?
  • some fields mentioned in documentation as enum, but in the code they are Strings, should I convert them to enums/mention that they enums in doc comments/do not change anything there?

@XAMPPRocky
Copy link
Owner

You can remove the redundant structure and make them enums, just make sure they're non_exhaustive.

@vlad1slav vlad1slav marked this pull request as ready for review November 11, 2024 14:43
@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 5f6b085 into XAMPPRocky:main Nov 13, 2024
20 checks passed
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
@vlad1slav vlad1slav deleted the security_alerts branch November 13, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants