Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional webhook model fields #696

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

backwardspy
Copy link
Contributor

i'm building a webhook handler and switched to octocrab's models today instead of my own hand-rolled models. there were a couple of fields i needed that weren't supported, so i've added them in and confirmed they seem to work as intended.

the naming of the repo change structs i added (owner/repo name) are a little confusing but the nesting is so deep i wasn't sure which way to go with it. let me know if you'd prefer something else!

if it helps at all, i have some example deliveries with these fields on them:

@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 5ffd531 into XAMPPRocky:main Sep 27, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
@backwardspy backwardspy deleted the feat/webhook-model-fields branch September 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants