fix: use put instead of get for set_thread_subscription #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
set_thread_subscription()
API of the Notification API was supposed to use the PUT method according to the documentation. The implementation was using GET, so I changed it to PUT.Additional Context
When I used PUT, the Not Found error no longer appeared.
However, the deserialization of the response type
ThreadSubscription
failed.The cause was that the
reason
field was an empty string. (not null)As a result, I was able to successfully change the thread subscription with the following code: