Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo fmt #658

Merged
merged 1 commit into from
Jun 14, 2024
Merged

cargo fmt #658

merged 1 commit into from
Jun 14, 2024

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Jun 13, 2024

Looks like this was forgotten before the latest merge commit.

@XAMPPRocky
Copy link
Owner

Thank you for your PR! Would you mind also adding to the CI check so we can prevent it happening in the future?

@maflcko
Copy link
Contributor Author

maflcko commented Jun 14, 2024

I already added it to the CI :)

See CI run https://github.com/XAMPPRocky/octocrab/actions/runs/9484551402/job/26134293504 of commit f10ab52 in the main branch.

The problem was that the CI didn't run on the last merged pull request. I think a setting exists in GitHub to prevent a merge before CI, but I haven't confirmed it.

@XAMPPRocky
Copy link
Owner

Ah right, gotcha. Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 5540ad8 into XAMPPRocky:main Jun 14, 2024
11 checks passed
@maflcko maflcko deleted the 2406-fmt branch June 14, 2024 07:49
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
This was referenced Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants