Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): Change add_retry_config signature to match other Builder methods #643

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

davidsow
Copy link
Contributor

Makes add_retry_config() adhere to standard set by other methods in the builder.
This has been tested locally and appears to work exactly as expected given attached usage example.

Usage example:
image

Closes #642

@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 0769768 into XAMPPRocky:main Jun 12, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
dmgorsky pushed a commit to dmgorsky/octocrab that referenced this pull request Jun 14, 2024
XAMPPRocky pushed a commit that referenced this pull request Jun 17, 2024
* added /user/blocks functionality (is_blocked, block_user, unblock_user, list_blocked)

* Update issues.rs (#634)

* fix(builder): Change add_retry_config signature to match others in OctocrabBuilder (#643)

* Fix issue #635 (#637)

---------

Co-authored-by: Artur Yurii Korchynskyi <[email protected]>
Co-authored-by: Kleo Davidson <[email protected]>
Co-authored-by: Hans Avontuur <[email protected]>
This was referenced Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder add_retry_config requires intermediate variable binding
2 participants