Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify diff entry models #624

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Unify diff entry models #624

merged 2 commits into from
Apr 4, 2024

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Apr 4, 2024 •
edited
Loading

Fixes #623

IDK which one would the best “source of truth”.

Maybe commits would make most sense? commits and repos share a lot of structs, I think. But commits::GitCommitObject already uses a bunch of things from repos

@flying-sheep flying-sheep mentioned this pull request Apr 4, 2024
Merged
@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 67c316f into XAMPPRocky:main Apr 4, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Mar 29, 2024
Merged
@flying-sheep flying-sheep deleted the fix-diff-entry branch April 5, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model bug in DiffEntry: Submodules have "blob_url": null and "raw_url": null
2 participants
@flying-sheep @XAMPPRocky