Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow directly passing SecretString #601

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Allow directly passing SecretString #601

merged 2 commits into from
Mar 15, 2024

Conversation

flying-sheep
Copy link
Contributor

Fixes #594

@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 388c185 into XAMPPRocky:main Mar 15, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Merged
@flying-sheep flying-sheep deleted the public-secret branch March 15, 2024 14:20
@flying-sheep
Copy link
Contributor Author

Thanks! octocrab is really nice and well designed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot directly pass SecretString for token auth
2 participants
@flying-sheep @XAMPPRocky