added repos/list_contributors #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2023 14:09
|
@XAMPPRocky This workflow requires approval from a maintainer. |
manchicken
reviewed
Dec 15, 2023
| } | ||
|
|
||
| /// Set to 1 or true to include anonymous contributors in results. | ||
| pub fn anon(mut self, include_anon: impl Into<bool>) -> Self { |
There was a problem hiding this comment.
Dumb question: does it matter that these aren't &mut self? It seems like you'd want this to be a reference, no?
There was a problem hiding this comment.
Here we consume self and then return it, as a part of a builder pattern.
There was a problem hiding this comment.
That makes sense, sorry I missed it the first go-round.
|
This looks great, I can't wait to use it! |
|
@XAMPPRocky This workflow requires approval from a maintainer 😇 |
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolving #490