Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tracing debug only when tracing feature is enabled #454

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

suryapandian
Copy link
Contributor

@suryapandian suryapandian commented Sep 4, 2023

Since the recent octocrab update we have started getting this error during build time

error[E0433]: failed to resolve: use of undeclared crate or module `tracing`
    --> /home/********/.cargo/registry/src/index.crates.io-6f17d22bba15001f/octocrab-0.30.0/src/lib.rs:1414:9
     |
1414 |         tracing::debug!("Token expires at: {:?}", expiration);
     |         ^^^^^^^ use of undeclared crate or module `tracing`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `octocrab` (lib) due to previous error

Noticed that this PR introduces tracing::debug
When projects do not enable the tracing feature, we get this build error.

Please review this PR which will fix the compile time error

@suryapandian suryapandian changed the title add tracing debug only when tracing feature is enabled fix: add tracing debug only when tracing feature is enabled Sep 4, 2023
@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit c454f3a into XAMPPRocky:main Sep 4, 2023
10 checks passed
@github-actions github-actions bot mentioned this pull request Sep 4, 2023
@suryapandian suryapandian deleted the feature branch September 4, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants