Add Webhook events payload deserialization #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagbo
force-pushed
the
feat/add_webhook_payloads
branch
from
3c2073c to
1b74556
Compare
|
The main issue with the PR is that there is not a lot of documentation about webhook events schema. So I will only fill the data for the payloads I got examples for, and mostly leave "optimistic" types where possible. |
gagbo
force-pushed
the
feat/add_webhook_payloads
branch
4 times, most recently
from
5b023ca to
ce4a715
Compare
Implement deserialization of payloads as described in https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads The payloads themselves do not implement `Deserialize`, since the event type information is located in headers, not in the payload itself.
gagbo
force-pushed
the
feat/add_webhook_payloads
branch
from
ce4a715 to
ee17078
Compare
|
I still need to flesh out the documentation I think |
|
Thank you for your PR! Feel free to make a follow-up PR with the documentation. 🙂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will be force pushed regularly, as progressively elements
for which we have example payloads will be more precise than just
serde_json::Value. This commit is pushed to enable an initial reviewover the architecture/scope of the changes.
Closes #419