fix: wrap pull_request_review_id in an Option

[0xB10C]

In some instances, the GitHub API returns null for the pull_request_review_id field. Calling octocrab::pulls::PullRequestHandler::list_comments() errors with invalid type: null, expected expected ReviewId as number or string. This happens, for example, when loading the comments for PR 1772 in bitcoin/bitcoin which returns:

[
  {
    "url": "https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/1525240",
    "pull_request_review_id": null,
    "id": 1525240,
    "node_id": "MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE1MjUyNDA=",
...

To avoid serialization problems, the field is wrapped in an Option.

[0xB10C]

See this tester too: https://gist.github.com/0xB10C/7fb0b4c6872e0bbd65c7fe05adebf999#file-main-rs

(switching out the octocrab dependency in Cargo.toml with octocrab = { git="https://github.com/0xb10c/octocrab.git", branch="2023-05-option-pull_request_review_id" } demonstrates that this indeed fixes it. Happy to add a test-case for this too if that'd be helpful.)

[maflcko]

Are you sure this is a bug? The upstream schema is:

     "pull_request_review_id": {
        "type": [
          "integer",
          "null"
        ],
        "examples": [
          42
        ]
      },

[maflcko]

thanks, code changes lgtm, but description seems wrong?

[0xB10C]

Ah you're right, thanks. I had only checked if the field is "required". Updated OP.

[XAMPPRocky]

Thank you for your PR!