Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hyperx dep; Manually inspect 'Link' header #258

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Remove hyperx dep; Manually inspect 'Link' header #258

merged 2 commits into from
Mar 21, 2023

Conversation

lpotthast
Copy link
Contributor

As stated multiple times in #110, the existence of the hyperx dependency causes more trouble than it brings functionality.

This PR removes the dependency altogether, replacing the small bits which were actually used with some custom logic.

Note:
Alternatively to merging this, one could hope that merging dekellum/hyperx#40 will resolve all our problems...

@oovm
Copy link

oovm commented Dec 20, 2022

Please follow up this PR, this branch works fine.

I have encountered some dependency conflicts of percent-encoding and cannot use octocrab in combination with other frameworks.

@drshade
Copy link

drshade commented Mar 21, 2023

Thanks - I have tested this and it does seem to fix my dependency conflict relating to hyperx.

My workaround is setting my octocrab dependency to:

octocrab = { git = "https://github.com/lpotthast/octocrab", branch = "remove-hyperx" }

Which allows me to move compile and move forward for now...

@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 7694573 into XAMPPRocky:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants