IssueHandle::delete_label panics

[chorman0773]

(Code is using octocrab = "0.30.1")
When calling IssueHandle::delete_label, IssueHandle panics. This appears to be because it expects a response in Json format, but according to github's documentation, the endpoint does not return any data (on success, it yields 204 No Content).

[chorman0773]

Correction: It is returning an error, rather than panicking (the backtrace was throwing me off). However, the root cause of the issue remains: it's trying to parse a response that the API does not provide.

[XAMPPRocky]

Thank you for your issue! I don't have time to fix this myself right now, but the solution is simple, we just need use _delete instead of delete which doesn't try any of the parsing of the request.

[chorman0773]

I actually wrote a fix (running on the tool I was writing to find this), and I'll file a PR later today.

…

On Tue, 5 Sept 2023 at 07:21, XAMPPRocky ***@***.***> wrote: Thank you for your issue! I don't have time to fix this myself right now, but the solution is simple, we just need use _delete instead of delete which doesn't try any of the parsing of the request. — Reply to this email directly, view it on GitHub <#456 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGLD24C4A3DB7SUC6RRJLDXY4DK5ANCNFSM6AAAAAA4LRMI54> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[manchicken]

I think the PR I just submitted yesterday, #503 should resolve this.

[XAMPPRocky]

Thank you for your issue!