REOPENED - Integrate Revival Protocol Fixes in CHL #1237 #1399
Conversation
BlackDog86
added
bug-basegame
waiting-on-author
In cases like this I would defer to in-game localization and reasonable player expectations. Localization goes:
"an ally" would reasonably include any allied unit, including resistance soldiers. The ability itself engages the GREMLIN to perform actions on a unit, requiring no special training or equipment from the unit, other than being human or close enough to a human (Skirmishers), so a reasonable person would expect it to be able to target resistance soldiers. So I'd say yeah, valid change. |
|
This PR seems to be missing the .x2proj change with addition of new files. |
BlackDog86
force-pushed
the
1235-Revival-Protocol-Fix
branch
from
283aa71
to
0831ff7
Compare
Resolved :) |
BlackDog86
added
ready-to-review
|
Sorry, but it needs to be in a separate commit. |
BlackDog86
force-pushed
the
1235-Revival-Protocol-Fix
branch
from
0831ff7
to
4587755
Compare
|
That should do it |
|
|
||
| // Start Issue #1235 | ||
| /// HL-Docs: ref:Bugfixes; issue:1235 | ||
| /// Update the ability template to call recover from stun & add a new condition to the Restore Action Point effect |
There was a problem hiding this comment.
Sorry, but I have to nitpick to these docs, they need to be user-facing and explain what specific bugs are getting fixed in plain terms.
| /// HL-Docs: ref:Bugfixes; issue:1235 | ||
| /// Update the ability template to call recover from stun & add a new condition to the Restore Action Point effect | ||
| Template.AddTargetEffect(class'X2StatusEffects'.static.CreateStunRecoverEffect()); | ||
| /// Restore APs on the unit only if the new X2Condition is met |
There was a problem hiding this comment.
This comment should be a simple double //
BlackDog86
force-pushed
the
1235-Revival-Protocol-Fix
branch
from
09bf984
to
cf391d7
Compare
|
Updated the docs to be more descriptive and removed the errant / |
|
Closing this in favor of #1415, which adds more bugfixes. |
Fixes #1235
Reopening accidentally closed request.
Adds custom X2Condition to the RestoreActionPoints effect of Revival Protocol to prevent it from restoring APs to disoriented units. Updated the ability targetting condition to allow revival protocol to target stunned units, remove the stunned status and restore APs properly. Also integrated the additional targeting condition from RMs mod which allows the ability to target resistance soldiers. Discussion to be had over whether this part is required/necessary.
Still requires finessing & testing before merge.