Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Low Intel warnings if all regions are contacted #1388

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented Sep 9, 2024

Fixes #1347

Alternative implementation of #1346, which addressed specifically the Low Intel popup, but not Low Intel icon in the lower left corner of the Geoscape, and probably more UI elements that make use of class'UIUtilities_Strategy'.static.GetMinimumContactCost() function.

I tested and it works as intended at least for the post-mission popup and the Geoscape icon.

@Iridar Iridar added bug-basegame ready-to-review A pull request is ready to be reviewed labels Sep 9, 2024
@Iridar Iridar added this to the 1.29.0 milestone Sep 9, 2024
@Iridar Iridar self-assigned this Sep 9, 2024
@BlackDog86
Copy link
Contributor

Let me know if you'd like this PR tested on my side as well

@Iridar
Copy link
Contributor Author

Iridar commented Nov 2, 2024

Yeah that would be appreciated, not thrilled about merging submissions without at least some kind of peer review.

@Iridar Iridar removed the ready-to-review A pull request is ready to be reviewed label Nov 28, 2024
@Iridar Iridar merged commit 7f08e85 into X2CommunityCore:master Nov 28, 2024
4 checks passed
@Iridar Iridar deleted the 1347-low-intel-warning branch November 28, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistent "Low Intel" warning after contacting all regions
3 participants