Allow mods to easily disable automatic photobooth photos

[BlackDog86]

Several places in the base-game code create automatic photobooth posters. Many players prefer to take their own photobooth shots and would prefer that the game doesn't automatically create these under different circumstances. Also the auto-photos seem to be mainly of horrible quality compared with user-taken shots, though I've not traced the codepath, perhaps the default resolution for user-generated photos is different but anyway, mostly they look like garbage.

Preliminary investigation reveals the following culprits:

AUTO-DEAD:
UIAfterAction::LoadPhotoboothAutoGenDeadSoldiers
(Called from InitScreen - Takes automatic photos of dead soldiers above rank 3)
AUTO-PROMO:
XComHQPresentationLayer::UIArmory_Promotion
(Takes automatic photos of soldiers when promoting to Rank 3 or Rank 6)
AUTO-BONDED:
UISoldierBondConfirmScreen::KickOffAutoGen
(Weirdly, automatically generates a photo and then asks the user if they want to create their own)
AUTO-MISSION:
UIMissionSummary::CloseScreenTakePhoto
(Automatically takes a mission photo with the full squad in it, if the user didn't take one themselves)

May I suggest gating all of these checks behind a config flag so they can be turned off easily without having to MCO each of these classes (In particularly XComHQPresentationLayer is probably not a great one to need MCOing).

An alternative approach may be to adjust X2Photobooth_StrategyAutoGen and X2Photobooth_TacticalAutoGen which are ultimately called by these functions but it's probably better to gate the calls at source rather than adjut the functions themselves which has a higher chance of messing with other base-game behaviour that may call / create these classes (they are used for soldier headshots and quite possibly various other modded things)

[Iridar]

Is auto dead used for memorial?

[BlackDog86]

No, when you click the memorialize button in after-action, that fires the OnClickedMemorialize method of UIAfterAction_ListItem which boots up the UIArmory_Photobooth for you to take the photo yourself.

[Iridar]

Doesn't memorial generate some kind of photo automatically?

[BlackDog86]

Apart from the auto-generated one that is saved into the posters archive (which is the one I'm trying to remove), a head-shot photo is also created for the memorial screen - insofar as I can tell, that one is generated in UIPersonnel_DeceasedListItem::Updatedata, if that's what you're referring to? Obviously we need to preserve the in-game headshots in their entirity as they're used all over the place.

[Dragon-32]

Personally rather than a single config. gate I'd appreciate multiple. Some of these I want (on dying), some of these I don't (the rest). However I don't know what that would involve, and the comments imply it's rather involved. If it's a choice between a single config. value and none then I'd choose to be able to disable them all.

[BlackDog86]

That'd be easy enough to do. In testing it seems relatively inconsequential to suppress the promotion, bond and end-of-mission photos but I'm having a bit more trouble with the 'mission-end-dead-guy' photo at the moment. I think it's being called from somewhere else than where I initially thought.

[BlackDog86]

OK so it's a bit clearer to me now what's going on. The proposed fix works, in its entirity, but it's being over-ridden in modded setups by a couple of common mods. Rusty's 'After Action Extended' and LEBs 'Configurable Headshots' over-ride the config flag which takes photos of dead guys at the end of the mission. In AAE this is a relatively uncomplicated MCO so just adding the HL flag into that mod will be sufficient to fix that issue & Rusty has already agreed to do it so no issue, I can't really work out what Configurable Headshots is doing, but nevertheless, with that mod enabled, a dead soldier photo will be taken at the end of the mission, shown on the skyranger screen as the 'last taken photo' when returning back to the avenger and then appears in the photobooth. Still, these are all downstream mod issues and testing in a pure environment, the code suppresses all autogen photos without messing around with headshots in any conceivable way.